Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH v4 5/6] fat: permit to return phy block number by fibmap in fallocated region | Date | Wed, 19 Mar 2014 00:29:32 +0900 |
| |
Namjae Jeon <linkinjeon@gmail.com> writes:
> +int fat_bmap2(struct inode *inode, sector_t sector, > + unsigned long *mapped_blocks, struct buffer_head *bh_result, > + int create, sector_t *bmap) > +{ > + struct super_block *sb = inode->i_sb; > + sector_t last_block; > + const unsigned long blocksize = sb->s_blocksize; > + const unsigned char blocksize_bits = sb->s_blocksize_bits; > + > + BUG_ON(create != 0); > + > + *bmap = 0; > + *mapped_blocks = 0; > + > + last_block = (MSDOS_I(inode)->i_disksize + (blocksize - 1)) > + >> blocksize_bits; > + > + if (sector >= last_block) > + return 0; > + > + return fat_get_mapped_cluster(inode, sector, last_block, mapped_blocks, > + bmap);
Maybe, we are better to merge fat_bmap2() and fat_get_block_bmap()? fat_bmap2() seems to be pointless. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |