Messages in this thread | | | Date | Mon, 17 Mar 2014 12:12:45 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v2 2/2] irqchip: sun4i: simplify sun4i_irq_ack |
| |
On Sat, Mar 15, 2014 at 04:04:54PM +0100, Hans de Goede wrote: > Now that we only ack irq 0 the code can be simplified a lot. > > Also switch from read / modify / write to a simple write clear: > 1) This is what the android code does (it has a hack for acking irq 0 > in its unmask code doing this) > 2) read / modify / write simply does not make sense for an irq status > register like this, if the other bits are writeable (and the data sheet says > they are not) they should be write 1 to clear, since otherwise a read / > modify / write can race with a device raising an interrupt and then clear > the pending bit unintentionally > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |