lkml.org 
[lkml]   [2014]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver
On Mon, Mar 17, 2014 at 09:45:40AM +0000, Bo Shen wrote:
> From: Boris BREZILLON <b.brezillon@overkiz.com>
>
> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
>
> Documentation/devicetree/bindings/sound/atmel-wm8904.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt
> index 8bbe50c..aca341c 100644
> --- a/Documentation/devicetree/bindings/sound/atmel-wm8904.txt
> +++ b/Documentation/devicetree/bindings/sound/atmel-wm8904.txt
> @@ -3,6 +3,8 @@ Atmel ASoC driver with wm8904 audio codec complex
> Required properties:
> - compatible: "atmel,asoc-wm8904"
> - atmel,model: The user-visible name of this sound complex.
> + - clocks: A list of clocks needed by the wm8904 chip.
> + - clock-output-names: Driver related clock names. Shall contain "pck0".

The word "driver" doesn't need to appear in biding documents, and this
fails to describe what it sets out to. How about the following:

- clocks: a list of phandle + clock-specifier pairs, one for each entry
in clock-names.
- clock-names: Should contain "pck0"

Thanks,
Mark.

\
 
 \ /
  Last update: 2014-03-17 11:41    [W:0.152 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site