Messages in this thread | | | Date | Fri, 14 Mar 2014 07:43:25 +0100 | From | Mike Looijmans <> | Subject | Re: [PATCH] i2c-davinci: Handle signals gracefully |
| |
On 03/10/2014 04:24 PM, Wolfram Sang wrote: > >>>> Even more, you should complete the whole transfer. There are devices >>>> where things can really go wrong if you send a half-complete command and >>>> then start with the next one. So, not checking signals at all is the way >>>> to go for I2C drivers. There is some cruft left, so I am happy about >>>> patches fixing that, with testing on real HW. Like yours here. >>> >>> I agree. >>> >>> I know the Zynq (using a cadence controller) also lets signals >>> interrupt I2C transfers, so I'll propose a patch to Xilinx and CC to >>> you and linux-i2c to completely remove signal handling from that >>> driver as well. >> >> Cool, thanks! > > Are you going to update the davinci patch as well?
An amended patch is on its way now. I forgot to set the subject to "PATCHv2" though.
Mike.
Met vriendelijke groet / kind regards,
Mike Looijmans
TOPIC Embedded Systems Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best Telefoon: (+31) (0) 499 33 69 79 Telefax: (+31) (0) 499 33 69 70 E-mail: mike.looijmans@topic.nl Website: www.topic.nl
Please consider the environment before printing this e-mail
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |