Messages in this thread | | | From | Ohad Ben-Cohen <> | Date | Fri, 14 Mar 2014 15:12:26 +0200 | Subject | Re: [PATCHv4 4/7] hwspinlock/core: add common OF helpers |
| |
On Sun, Mar 2, 2014 at 10:19 PM, Bjorn Andersson <bjorn@kryo.se> wrote: > When introducing the ability to reference a hwspin lock via a phandle > in device tree it makes a big difference to be able to differ between > the case of "initialization failed" or "device not yet probed"; so > that the client knows if it should fail or retry later.
I'm not convinced.
The only advantage this brings is to avoid retrying in case a fatal error has occurred. Such fatal errors are extremely rare, and when they show up - extremely painful, and I suspect that optimizing them wouldn't be a big win.
OTOH, keeping the code easier to read and less error prone is a big win. I prefer we keep it simple for now.
Thanks, Ohad.
| |