Messages in this thread | | | Date | Thu, 13 Mar 2014 10:12:35 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver |
| |
Hi!
> > 30*HZ means 30 seconds in the kernel... what is hard to understand > > about it? > > Well I might be picky, but since it is a charging algorithm dealing with > ampères, volts, constant-current/constant-voltage, watchdogs and > timeouts, all stated in SI units, it would be nice if all such constants > were specified in simple units instead of kernel-specific terms.
I agree HZ is badly named, but hopefully anyone working on kernel is already familiar with it.
But... what would actually help: I believe we should introduce milivolt_t, miliamp_t, milisec_t etc... types. Storing milivolts in int, then having comment saying "milivolts" is just wrong.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |