Messages in this thread | | | Date | Thu, 13 Mar 2014 09:38:32 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH V2] Change ACPI IPMI support to "default y" |
| |
On Thu 2014-03-13 07:24:36, Matthew Garrett wrote: > On Thu, 2014-03-13 at 08:22 +0100, Pavel Machek wrote: > > On Wed 2014-03-12 23:22:49, Matthew Garrett wrote: > > > No. The power meter driver knows nothing about IPMI. It makes no IPMI > > > calls. There's no requirement that a vendor implement it via IPMI. > > > > Yet you claim that IMPI is needed for that, and that's why you made > > IMPI default. > > I claim that the ACPI spec defines the behaviour of IPMI operation > regions, and so we should default IPMI to Y in order to (by default) > implement the ACPI spec. > > > So ... do we need dmi-based blacklist? > > I don't see why.
Your reasoning for default y was that "power meter depends on this". Then, claim that "power meter does not officially depend on it" so it would be wrong to have a dependency.
Defaults are not right solution; system should still work if I select non-default settings. Which you claim is not a case, but you don't see why you should fix it. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |