Messages in this thread | | | Date | Thu, 13 Mar 2014 10:17:04 +0000 | From | Sebastian Hesselbarth <> | Subject | Re: [PATCH 1/2] ARM: dts: berlin2q: add the Marvell Armada 1500 pro (BG2Q) device tree |
| |
On 03/13/2014 10:08 AM, Alexandre Belloni wrote: > On 13/03/2014 at 09:56:48 +0000, Sebastian Hesselbarth wrote : >> On 03/12/2014 12:22 PM, Alexandre Belloni wrote: >>> >>> The 25MHz crystal is on the board, please move it to the board dts. >> >> If you can confirm that sysmgr clock comes directly from this crystal, >> I agree. If it is fed into a pll and can possibly be modified or gated, >> make it depend on a 25MHz board crystal. If 25MHz is the only option >> for this clock input, I could also live with it being part of the SoC >> description. >> > > Yeah, after more discussion, the 25 MHz crystl is the only option and it > is fed to an oscillator that generate the reference clock for the PLLs. > It is probably fine to let it in the dtsi. >
Fine, I am planing to do more work on Berlin and especially clocks next cycle. So most of the fixed-clocks will vanish anyway.
BTW, back at ELCE/ARM summit I successfully enabled SMP for berlin2. I'll dig that patch out for you to re-test on Quad-core bg2q.
Sebastian
| |