Messages in this thread | | | Date | Thu, 13 Mar 2014 20:35:43 +0100 | Subject | Re: [PATCH] perf/x86/uncore: fix missing end markers for SNB/IVB/HSW IMC PMU | From | Stephane Eranian <> |
| |
On Thu, Mar 13, 2014 at 6:17 PM, Andi Kleen <andi@firstfloor.org> wrote: > Stephane Eranian <eranian@google.com> writes: > >> This patch fixes a bug with the SNB/IVB/HSW uncore >> mmeory controller support. >> >> The PCI Ids tables for the memory controller were missing end markers. >> That could cause random crashes on boot during or after PCI device >> registration. > > I wonder if there's a way to check this in checkpatch.pl ? > > Or maybe a sparse check could be added, with a new type attribute > that says "needs to be 0 terminate" > Not that easy , because in some cases, the size may be passed as a parameter to the call or maybe embedded into a struct passed to the call. But if you target this specific macro, you should be able to find the issues.
> -Andi > > -- > ak@linux.intel.com -- Speaking for myself only
| |