Messages in this thread | | | Date | Thu, 13 Mar 2014 14:13:17 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regmap: irq: Set data pointer only on regmap_add_irq_chip success |
| |
On Thu, Mar 13, 2014 at 09:06:01AM +0100, Krzysztof Kozlowski wrote: > After setting the 'data' pointer (wchich is returned to the caller for > freeing later) the regmap_add_irq_chip() could still fail for various > reasons (ENOMEM, regmap_read or regmap_write failure). In such case the > memory under 'data' was freed in error path and error value was returned > but the 'data' variable was not changed. > > This could lead to errors if the caller passed such 'data' to > regmap_del_irq_chip().
If the user is calling regmap_del_irq_chip() after the add failed then I'd expect things to break anyway... [unhandled content-type:application/pgp-signature] | |