lkml.org 
[lkml]   [2014]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] irq: Add a new IRQF_ACK_BEFORE_UNMASK irq flag
On Wed, 12 Mar 2014, Hans de Goede wrote:
> This indeed seems the best solution. I'm going to send a v2
> of my sun4i irq patch-set with this patch included with 2 fixes added:
>
> 1) Export the prototype for the new handle_fasteoi_late_irq function
> 2) Fix the minor issue Russell noticed
>
> I've only one minor nitpick wrt this patch, for ONESHOT
> to work properly the irq_chip for an irq_desc using
> handle_fasteoi_late_irq must set the IRQCHIP_EOI_THREADED, but
> this is not enforced anywhere.
>
> Maybe add a BUG_ON to the irq mapping code checking this ?

We want some info, but a BUG_ON is probably overkill. I'll think about
a good place to do this.

Thanks,

tglx


\
 
 \ /
  Last update: 2014-03-13 00:01    [W:0.250 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site