lkml.org 
[lkml]   [2014]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V7 1/1] drivers/gpio: Altera soft IP GPIO driver and devicetree binding
From
On Sat, Mar 8, 2014 at 12:50 PM, Gerhard Sittig <gsi@denx.de> wrote:
> On Fri, Mar 07, 2014 at 11:31 +0800, Linus Walleij wrote:
>>
>> On Mon, Mar 3, 2014 at 6:27 PM, <thloh@altera.com> wrote:
>>
>> > From: Tien Hock Loh <thloh@altera.com>
>> >
>> > Add driver support for Altera GPIO soft IP, including interrupts and I/O.
>> > Tested on Altera CV SoC board using dipsw and LED using LED framework.
>> >
>> > Signed-off-by: Tien Hock Loh <thloh@altera.com>
>>
>> Can I get some ACKs on this? Like from Gerhard, DT folks?
>>
>> Or is there still more things to do?
>
> Sorry, had flagged the patch for review, but did not get around
> to respond earlier. No ACK from me for v7 as it is.

OK I'm holding this back.

> Am I supposed to provide ACKs at all, given that I'm a reviewer
> and fellow developer. I always understood that Acked-By is
> something more formal, where one maintainer signals to another
> maintainer that it's OK to go though a different tree.

In this case I want an Acked-by/Reviewed-by tag (choose!)
beacuse I trust your ability to review this specific code, as simple as
that. :-)

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2014-03-12 16:41    [W:0.131 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site