Messages in this thread | | | Date | Wed, 12 Mar 2014 15:32:59 +0100 | Subject | Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver | From | Linus Walleij <> |
| |
On Mon, Mar 10, 2014 at 5:33 AM, Jenny Tc <jenny.tc@intel.com> wrote: > On Fri, Mar 07, 2014 at 09:25:20PM +0100, Pavel Machek wrote:
>> > + /* sort based on priority. 0 has the highest priority */ >> > + for (i = 0; i < cnt; ++i) >> > + for (j = 0; j < cnt; ++j) >> > + if (psy_prioirty(psy_lst[j]) > psy_prioirty(psy_lst[i])) >> > + swap(psy_lst[j], psy_lst[i]); >> > + >> >> WTF? Bubble sort in kernel? > > Yes, it's bubble sort. Since the number of power supply objects in real systems > (max 4) are limited, I feel the complexity would be as same as any other > sorting algorithms. Any suggestions?
You already have a kernel quicksort implementation in lib/sort.c.
Please restructure the code to make use of this as it is already compiled into every kernel.
Yours, Linus Walleij
| |