Messages in this thread | | | Date | Tue, 11 Mar 2014 14:26:07 -0700 | Subject | Re: [PATCH 3/7] ARM: zynq: Hang iomapped slcr address on device_node | From | Olof Johansson <> |
| |
On Mon, Jan 6, 2014 at 6:36 AM, Michal Simek <michal.simek@xilinx.com> wrote: > From: Steffen Trumtrar <s.trumtrar@pengutronix.de> > > For later usage by zynq clk driver. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > arch/arm/mach-zynq/slcr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-zynq/slcr.c b/arch/arm/mach-zynq/slcr.c > index 9746de7..2891dcf 100644 > --- a/arch/arm/mach-zynq/slcr.c > +++ b/arch/arm/mach-zynq/slcr.c > @@ -121,6 +121,8 @@ int __init zynq_early_slcr_init(void) > BUG(); > } > > + np->data = (__force void *)zynq_slcr_base;
This is quite unusual, we normally remap again if needed. Is there a reason you can't just have the driver request the resource and map it like most other ones do?
-Olof
| |