Messages in this thread | | | Date | Tue, 11 Mar 2014 17:31:24 +0100 | From | Alexander Gordeev <> | Subject | Re: [PATCH RESEND 1/3] percpu_ida: Fix data race on cpus_have_tags cpumask |
| |
On Tue, Mar 11, 2014 at 11:34:21PM +0800, Ming Lei wrote: > I mean the below block can be put inside the previous lock:
Oh, *now* I see what you mean. Please, ignore my prevous reply. Still, we want to release the lock as soon as possible and there is no reason to the below bits it under lock.
> if (nr_free == 1) > cpumask_set_cpu() > > As I mentioned, 'nr_free == 1' doesn't happen frequently, so > it won't be big deal, will it?
-- Regards, Alexander Gordeev agordeev@redhat.com
| |