Messages in this thread | | | Date | Tue, 11 Mar 2014 11:12:34 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v3 2/5] pinctrl: st: Enhance the controller to manage unavailable registers |
| |
> >>From: Giuseppe Cavallaro <peppe.cavallaro@st.com> > >> > >>This patch adds a new logic inside the st pinctrl to manage > >>an unsupported scenario: some sysconfig are not available! > >> > >>This is the case of STiH407 where, although documented, the > >>following registers from SYSCFG_FLASH have been removed from the SoC. > >> > >>SYSTEM_CONFIG3040 > >> Output Enable pad control for all PIO Alternate Functions > >>and > >>SYSTEM_ CONFIG3050 > >> Pull Up pad control for all PIO Alternate Functions > >> > >>Without managing this condition an imprecise external abort > >>will be detect. > >> > >>To do this the patch also reviews the st_parse_syscfgs > >>and other routines to manipulate the registers only if > >>actually available. > >>In any case, for example the st_parse_syscfgs detected > >>an error condition but no action was made in the > >>st_pctl_probe_dt. > >> > >>Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com> > >>Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
No problem with any of your comments. Once the fixups have been made, feel free to apply my:
Acked-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |