Messages in this thread | | | Date | Mon, 10 Mar 2014 23:56:00 +0100 | From | Hannes Frederic Sowa <> | Subject | Re: [PATCHv2 2/2] bridge: multicast: enable snooping on general queries only |
| |
On Mon, Mar 10, 2014 at 10:25:25PM +0100, Linus Lüssing wrote: > br_multicast_query_received(br, port, &br->ip6_querier, > - !ipv6_addr_any(&ip6h->saddr), max_delay); > + !ipv6_addr_any(&ip6h->saddr), > + is_general_query, max_delay);
Just a small nit, maybe for a later patch:
After your change 6565b9eeef194a ("bridge: multicast: add sanity check for query source addresses"), which is still in -net only, we could replace !ipv6_addr_any(&ip6h->saddr) with '1'?
Greetings,
Hannes
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |