| Date | Sat, 01 Mar 2014 11:48:11 +0000 | From | Jonathan Cameron <> | Subject | Re: [RFCv4 4/7] mfd: twl-core: Add twl_i2c_read/write_u16 |
| |
On 26/02/14 20:03, Sebastian Reichel wrote: > Add a simple twl_i2c_read/write_u16 wrapper over > the twl_i2c_read/write, which is similar to the > twl_i2c_read/write_u8 wrapper. > > Signed-off-by: Sebastian Reichel <sre@debian.org> > Acked-by: Lee Jones <lee.jones@linaro.org> Acked-by: Jonathan Cameron <jic23@kernel.org>
(I'll start a separate conversation about who will take this series in a mo).
> --- > include/linux/i2c/twl.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h > index ade1c06..d2b1670 100644 > --- a/include/linux/i2c/twl.h > +++ b/include/linux/i2c/twl.h > @@ -195,6 +195,18 @@ static inline int twl_i2c_read_u8(u8 mod_no, u8 *val, u8 reg) { > return twl_i2c_read(mod_no, val, reg, 1); > } > > Hmm. This had me confused for a few mins given word rights in i2c are guaranteed to be little endian unless the swapped versions are used. I see that the twl driver is using a generic i2c bulk write. Ah well, I can see that simplifies the regmap i2c code and works in most cases... +static inline int twl_i2c_write_u16(u8 mod_no, u16 val, u8 reg) { > + val = cpu_to_le16(val); > + return twl_i2c_write(mod_no, (u8*) &val, reg, 2); > +} > + > +static inline int twl_i2c_read_u16(u8 mod_no, u16 *val, u8 reg) { > + int ret; > + ret = twl_i2c_read(mod_no, (u8*) val, reg, 2); > + *val = le16_to_cpu(*val); > + return ret; > +} > + > int twl_get_type(void); > int twl_get_version(void); > int twl_get_hfclk_rate(void); >
|