Messages in this thread | | | Date | Sun, 9 Feb 2014 13:44:42 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] sched/wait: suppress sparse 'variable shadowing' warning |
| |
* Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 6 Feb 2014 17:45:58 +0100 > Peter Zijlstra <peterz@infradead.org> wrote: > > > On Thu, Feb 06, 2014 at 05:28:41PM +0100, Johannes Berg wrote: > > > From: Johannes Berg <johannes.berg@intel.com> > > > > > > This warning seems to show up a lot now, since ___wait_event() > > > is (indirectly) used inside wait_event_timeout(), which also > > > has a variable called __ret. Rename the one in ___wait_event() > > > to ___ret (another leading underscore) to suppress the warning. > > > > > > Signed-off-by: Johannes Berg <johannes.berg@intel.com> > > > > Thanks! > > Tag, you're it! > > Now you need to submit a patch to fix one sparse warning this week ;-) > > Yeah, yeah, I know. Like you have time. > > This could be a cool drinking game. Every time you fix someone else's > sparse error, they have to drink a pint :-)
... which game would result in a heightened mood amongst developers and even more Sparse errors, resulting in more fixes from PeterZ and more pints downed, creating a nice feedback loop. Sounds like fun for everyone, except Peter? ;-)
Thanks,
Ingo
| |