Messages in this thread | | | Date | Mon, 10 Feb 2014 10:56:34 +0800 | From | Dongsheng Yang <> | Subject | Re: [PATCH 1/3] sched: Move the priority specific bits into a new header file. |
| |
Hi Namhyung,
On 01/29/2014 01:28 PM, Namhyung Kim wrote: > Hi Dongsheng, > > On Mon, 27 Jan 2014 17:15:37 -0500, Dongsheng Yang wrote: >> Some bits about priority are defined in linux/sched/rt.h, but >> some of them are not only for rt scheduler, such as MAX_PRIO. >> >> This patch move them all into a new header file, linux/sched/prio.h. >> >> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com> >> --- >> include/linux/sched.h | 4 ++++ >> include/linux/sched/prio.h | 23 +++++++++++++++++++++++ >> include/linux/sched/rt.h | 21 +++------------------ >> 3 files changed, 30 insertions(+), 18 deletions(-) >> create mode 100644 include/linux/sched/prio.h >> >> diff --git a/include/linux/sched.h b/include/linux/sched.h >> index 68a0e84..ba1b732 100644 >> --- a/include/linux/sched.h >> +++ b/include/linux/sched.h >> @@ -3,6 +3,10 @@ >> >> #include <uapi/linux/sched.h> >> >> +#ifndef _SCHED_PRIO_H >> +#include <linux/sched/prio.h> >> +#endif /* #ifndef _SCHED_PRIO_H */ > It seems you don't need to use #ifndef-#endif pair to include a header > file?
Sorry for the late reply, coming back from vacation for Chinese Spring Festival.
The reason I use #ifndef-#endif here is that there are lots of files, such as kernel/sched/sched.h, are including <linux/sched.h> and <linux/sched/rt.h>. And both of them are including prio.h.
I am not sure should we avoid reincluding a file and how.
Could you help to give me some suggestion of it. Thanx :)
> Thanks, > Namhyung >
| |