Messages in this thread | | | Date | Sun, 09 Feb 2014 20:36:15 -0500 | From | Sasha Levin <> | Subject | Re: [GIT PULL] liblockdep fixes for v3.14 |
| |
On 02/09/2014 07:53 AM, Ingo Molnar wrote: > > * Sasha Levin <sasha.levin@oracle.com> wrote: > >> The following changes since commit 65370bdf881e20907e7a53abab9b8c0bc5f60a6b: >> >> Merge branch 'linus' into core/locking (2014-02-02 09:43:20 +0100) >> >> are available in the git repository at: >> >> >> https://github.com/sashalevin/liblockdep.git liblockdep-fixes >> >> for you to fetch changes up to a521b55af18ac72c969c1ba41b660d77dae37357: >> >> liblockdep: add a stub for new rcu_is_watching (2014-02-05 18:03:54 -0500) >> >> ---------------------------------------------------------------- >> Ira W. Snyder (3): >> tools: lockdep: fix initialization code path >> tools: lockdep: fix include of asm/hash.h >> tools: lockdep: add include directory to allow tests to compile >> >> Sasha Levin (2): >> liblockdep: mark runtests.sh as executable >> liblockdep: add a stub for new rcu_is_watching > > So I have a couple of nits about the commits: > > 1) > > Please use the following standard tags/prefixes: > > tools/liblockdep: Fix initialization code path > ... > > and also capitalize sentences properly. > > 2) > > Faulty SOB sequences: > > Author: Ira W. Snyder <iws@ovro.caltech.edu> > Date: Fri Jan 31 13:35:32 2014 -0800 > > tools: lockdep: add include directory to allow tests to compile > > Acked-by: Sasha Levin <sasha.levin@oracle.com> > Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu> > > > That's not how we do signoffs, maintainer commits should be: > > Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu> > Signed-off-by: Sasha Levin <sasha.levin@oracle.com> > > > As a side note, that's not a valid Ack sequence either, which if done > should be the other way around: > > Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu> > Acked-by: Sasha Levin <sasha.levin@oracle.com> > > 3) > > It's not clear which patch you are referring to here: > > This patch mirrors the fix used for perf, titled "tools: perf: > util: fix include for non x86 architectures". > > It's neither in the series, nor in upstream.
Thanks for the review Ingo, this was my first time doing a pull request. I'll fix everything and resend.
About 3, Arnaldo pulled that patch into -tip a week ago (https://lkml.org/lkml/2014/2/2/34).
Thanks, Sasha
| |