lkml.org 
[lkml]   [2014]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: max1363: Use devm_regulator_get_optional for optional regulator
On 27/01/14 18:10, Guenter Roeck wrote:
> In kernel version 3.13, devm_regulator_get() may return no error
> if a regulator is undeclared. regulator_get_voltage() will return
> -EINVAL if this happens. This causes the driver to fail loading if
> the vref regulator is not declared.
>
> Since vref is optional, call devm_regulator_get_optional instead.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Applied and marked for stable.

Thanks,
> ---
> Should be a candidate for -stable (v3.12+).
>
> drivers/iio/adc/max1363.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
> index e283f2f..3602592 100644
> --- a/drivers/iio/adc/max1363.c
> +++ b/drivers/iio/adc/max1363.c
> @@ -1560,7 +1560,7 @@ static int max1363_probe(struct i2c_client *client,
> st->client = client;
>
> st->vref_uv = st->chip_info->int_vref_mv * 1000;
> - vref = devm_regulator_get(&client->dev, "vref");
> + vref = devm_regulator_get_optional(&client->dev, "vref");
> if (!IS_ERR(vref)) {
> int vref_uv;
>
>



\
 
 \ /
  Last update: 2014-02-08 13:21    [W:0.318 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site