Messages in this thread | | | Date | Sat, 08 Feb 2014 18:14:22 -0500 | From | Sasha Levin <> | Subject | Re: [PATCH resend 1/2] liblockdep: Use realpath for srctree and objtree |
| |
Hi Wang,
Thanks! I've picked it up and will send it in the next pull request.
Thanks, Sasha
On 02/07/2014 08:43 PM, Wang Nan wrote: > If BUILD_SRC or CURDIR contains tailing '/', the file names passed to gcc will > contain '//'. It will be contained .o's in debuginfo, then confuse debugedit: > > https://bugzilla.redhat.com/show_bug.cgi?id=304121 > > This patch uses realpath command to makesure potential tailing '/'s are removed. > > Signed-off-by: Wang Nan <wangnan0@huawei.com> > Acked-by: Sasha Levin <sasha.levin@oracle.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Geng Hui <hui.geng@huawei.com> > > --- > tools/lib/lockdep/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/lib/lockdep/Makefile b/tools/lib/lockdep/Makefile > index da8b7aa..e638dd5 100644 > --- a/tools/lib/lockdep/Makefile > +++ b/tools/lib/lockdep/Makefile > @@ -87,8 +87,8 @@ endif # BUILD_SRC > # We process the rest of the Makefile if this is the final invocation of make > ifeq ($(skip-makefile),) > > -srctree := $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR)) > -objtree := $(CURDIR) > +srctree := $(realpath $(if $(BUILD_SRC),$(BUILD_SRC),$(CURDIR))) > +objtree := $(realpath $(CURDIR)) > src := $(srctree) > obj := $(objtree) > >
| |