lkml.org 
[lkml]   [2014]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 4/6] kbuild: Support padding in kallsyms tables
> With attached config I get:
>
> KSYM .tmp_kallsyms2.o
> kallsyms: address pointers padding too short: 24495 missing
> OBJCOPY .tmp_kallsyms2.bin
> PATCHFILE vmlinux
> Not enough padding in vmlinux for new kallsyms, missing 192120
> Makefile:840: recipe for target 'vmlinux' failed

Nice test case thanks. This should fix it.

diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index e479076..fb6898f 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -197,15 +197,19 @@ static int symbol_valid_tr(struct sym_entry *s)
{
size_t i;
struct text_range *tr;
+ int valid = 0;

for (i = 0; i < ARRAY_SIZE(text_ranges); ++i) {
tr = &text_ranges[i];

+ if (tr->start && tr->end)
+ valid++;
+
if (s->addr >= tr->start && s->addr <= tr->end)
return 1;
}

- return 0;
+ return valid ? 0 : 1;
}

static int symbol_valid(struct sym_entry *s)

\
 
 \ /
  Last update: 2014-02-08 19:01    [W:0.078 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site