Messages in this thread Patch in this message | | | Date | Sat, 8 Feb 2014 10:16:05 +0800 | From | Li Zefan <> | Subject | [PATCH 3/3] jffs2: remove wait queue after schedule() |
| |
@wait is a local variable, so if we don't remove it from the wait queue list, later wake_up() may end up accessing invalid memory.
This was spotted by eyes.
Cc: <stable@vger.kernel.org> Signed-off-by: Li Zefan <lizefan@huawei.com> --- fs/jffs2/nodemgmt.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/fs/jffs2/nodemgmt.c b/fs/jffs2/nodemgmt.c index fb30161..610a22c 100644 --- a/fs/jffs2/nodemgmt.c +++ b/fs/jffs2/nodemgmt.c @@ -179,6 +179,7 @@ int jffs2_reserve_space(struct jffs2_sb_info *c, uint32_t minsize, spin_unlock(&c->erase_completion_lock); schedule(); + remove_wait_queue(&c->erase_wait, &wait); } else spin_unlock(&c->erase_completion_lock); } else if (ret) -- 1.8.0.2
| |