Messages in this thread | | | Date | Fri, 7 Feb 2014 13:19:07 -0800 | From | Stephen Boyd <> | Subject | Re: [PATCH v2 1/5] ARM: msm: kill off hotplug.c |
| |
On 02/04, Kumar Gala wrote: > > On Feb 4, 2014, at 5:07 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: > > > On 02/04, Kumar Gala wrote: > >> diff --git a/arch/arm/mach-msm/platsmp.c b/arch/arm/mach-msm/platsmp.c > >> index 3721b31..251a91e 100644 > >> --- a/arch/arm/mach-msm/platsmp.c > >> +++ b/arch/arm/mach-msm/platsmp.c > >> @@ -29,6 +29,13 @@ extern void secondary_startup(void); > >> > >> static DEFINE_SPINLOCK(boot_lock); > >> > >> +#ifdef CONFIG_HOTPLUG_CPU > >> +static void __ref msm_cpu_die(unsigned int cpu) > > > > We shouldn't need __ref anymore either right? > > I think we might as cpu_die is still marked __ref so I think we need it. >
Someone should remove __ref from cpu_die() as well. It was only ever there for __cpuinit but now that __cpuinit is gone it's useless.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |