Messages in this thread | | | Date | Fri, 7 Feb 2014 10:01:57 -0800 | From | Greg KH <> | Subject | Re: [PATCH] staging: ced1401: fix coding style in ced_ioc.c (resend) |
| |
On Wed, Jan 15, 2014 at 10:37:13PM +0100, Pol Eyschen wrote: > Fixed checkpatch.pl issues and removed redundant comment in ced_ioc.cs > > Signed-off-by: Pol Eyschen <poleyschen@gmail.com> > --- > drivers/staging/ced1401/ced_ioc.c | 483 +++++++++++++++++++++---------------- > 1 file changed, 271 insertions(+), 212 deletions(-) > > diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c > index bf532b1..94a361d 100644 > --- a/drivers/staging/ced1401/ced_ioc.c > +++ b/drivers/staging/ced1401/ced_ioc.c > @@ -40,8 +40,8 @@ static void FlushOutBuff(DEVICE_EXTENSION *pdx) > { > dev_dbg(&pdx->interface->dev, "%s currentState=%d", __func__, > pdx->sCurrentState); > - if (pdx->sCurrentState == U14ERR_TIME) /* Do nothing if hardware in trouble */ > - return; > + if (pdx->sCurrentState == U14ERR_TIME) > + return; /* Do nothing if hardware in trouble */
That's really not a good cleanup, is it?
And this patch no longer applies to my tree, care to fix it up and resend?
thanks,
greg k-h
| |