Messages in this thread | | | Date | Fri, 07 Feb 2014 14:29:41 -0500 | From | Rik van Riel <> | Subject | Re: [patch] drop_caches: add some documentation and info message |
| |
On 02/07/2014 01:13 PM, Johannes Weiner wrote:
>> Would it be better to print this after the operation >> has completed? > > It would make more sense grammatically :-) Either way is fine with me, > updated below to inform after the fact.
Well, in principle the operation could take an arbitrarily long time, so there are some minor concerns besides grammatical correctness, too :)
Thanks for updating the patch.
> --- > From: Dave Hansen <dave@linux.vnet.ibm.com> > Date: Fri, 12 Oct 2012 14:30:54 +0200 > Subject: [patch] drop_caches: add some documentation and info message
> Dropping caches is a very drastic and disruptive operation that is > good for debugging and running tests, but if it creates bug reports > from production use, kernel developers should be aware of its use. > > Add a bit more documentation about it, and add a little KERN_NOTICE. > > [akpm@linux-foundation.org: checkpatch fixes] > Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com> > Signed-off-by: Michal Hocko <mhocko@suse.cz> > Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Rik van Riel <riel@redhat.com>
| |