Messages in this thread | | | Date | Fri, 7 Feb 2014 11:26:25 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] Modpost: fixed USB alias generation for ranges including 0x9 and 0xA |
| |
On Fri, Feb 07, 2014 at 07:15:11PM +0100, Jan Moskyto Matejka wrote: > Commit afe2dab4f6 ("USB: add hex/bcd detection to usb modalias generation") > changed the routine that generates alias ranges. Before that change, only > digits 0-9 were supported; the commit tried to fix the case when the range > includes higher values than 0x9. > > Unfortunately, the commit didn't fix the case when the range includes both > 0x9 and 0xA, meaning that the final range must look like [x-9A-y] where > x <= 0x9 and y >= 0xA -- instead the [x-9A-x] range was produced. > > Modprobe doesn't complain as it sees no difference between no-match and > bad-pattern results of fnmatch(). > > Fixing this simple bug to fix the aliases. > Also changing the hardcoded beginning of the range to uppercase as all the > other letters are also uppercase in the device version numbers. > > Fortunately, this affects only the dvb-usb-dib0700 module, AFAIK.
Thanks, I'll take this through the usb tree.
Odd that it's taken years for this to show up as an issue.
greg k-h
| |