Messages in this thread | | | Date | Fri, 7 Feb 2014 16:21:31 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH] mm: fix page leak at nfs_symlink() |
| |
On Fri, Feb 07, 2014 at 01:19:54PM -0200, Rafael Aquini wrote: > Changes committed by "a0b8cab3 mm: remove lru parameter from > __pagevec_lru_add and remove parts of pagevec API" have introduced > a call to add_to_page_cache_lru() which causes a leak in nfs_symlink() > as now the page gets an extra refcount that is not dropped. > > Jan Stancek observed and reported the leak effect while running test8 from > Connectathon Testsuite. After several iterations over the test case, > which creates several symlinks on a NFS mountpoint, the test system was > quickly getting into an out-of-memory scenario. > > This patch fixes the page leak by dropping that extra refcount > add_to_page_cache_lru() is grabbing. > > Signed-off-by: Jan Stancek <jstancek@redhat.com> > Signed-off-by: Rafael Aquini <aquini@redhat.com>
Thanks.
Acked-by: Mel Gorman <mgorman@suse.de>
It should be cc'd for stable for 3.11 and later kernels.
-- Mel Gorman SUSE Labs
| |