lkml.org 
[lkml]   [2014]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3.11 229/233] ALSA: hda - hdmi: introduce patch_nvhdmi()
    On Fri, Feb 07, 2014 at 12:58:47PM +0100, Levente Kurusa wrote:
    > Hi,
    >
    > On 02/07/2014 12:47 PM, Luis Henriques wrote:
    > > 3.11.10.4 -stable review patch. If anyone has any objections, please let me know.
    > > [...]
    > >
    > > +static int patch_nvhdmi(struct hda_codec *codec)
    > > +{
    > > + struct hdmi_spec *spec;
    > > + int err;
    > > +
    > > + err = patch_generic_hdmi(codec);
    > > + if (err)
    > > + return err;
    > > +
    > > + spec = codec->spec;
    > > +
    > > + return 0;
    > > +}
    > > [...]
    >
    > Is it just me or is it that the 'spec' variable has no use?

    This does seem a little bit odd indeed. I've picked the backport provided
    by Stephen, which has been queued for the 3.10 and 3.12 stable kernels as
    well. The original patch actually modifies the ops field in the hdmi_spec
    struct, however this field doesn't exist in this kernel version.

    Stephen, could you please comment? Since this is just a partial backport
    of 611885bc963a ("ALSA: hda - hdmi: Disallow unsupported 2ch remapping on
    NVIDIA codecs"), I'm assuming this is correct -- although the spec
    variable could have been dropped.

    Cheers,
    --
    Luis


    \
     
     \ /
      Last update: 2014-02-07 16:01    [W:4.040 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site