Messages in this thread | | | Date | Fri, 07 Feb 2014 12:12:30 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH 1/2] ALSA: hda/ca0132 - setup/cleanup streams |
| |
At Fri, 07 Feb 2014 11:59:20 +0100, Takashi Iwai wrote: > > At Fri, 7 Feb 2014 11:35:29 +0800, > Hsin-Yu Chao wrote: > > > > When a HDMI stream is opened with the same stream tag > > as a following opened stream to ca0132, audio will be > > heard from two ports simultaneously. > > Fix this issue by change to use snd_hda_codec_setup_stream > > and snd_hda_codec_cleanup_stream instead, so that an > > inactive stream can be marked as 'dirty' when found > > with a conflict stream tag, and then get purified. > > > > Signed-off-by: Hsin-Yu Chao <hychao@chromium.org> > > Reviewed-by: Chih-Chung Chang <chihchung@chromium.org> > > Thanks, applied this one.
Hrm, not good.
sound/pci/hda/patch_ca0132.c: In function ‘ca0132_playback_pcm_prepare’: sound/pci/hda/patch_ca0132.c:2675:2: error: implicit declaration of function ‘ca0132_toggle_dac_format’ [-Werror=implicit-function-declaration] ca0132_toggle_dac_format(codec); ^
Please give a patch that really builds and works cleanly with the upstream code!
thanks,
Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |