Messages in this thread | | | Date | Thu, 06 Feb 2014 10:32:43 +0100 | From | Takashi Iwai <> | Subject | Re: [PATCH] ALSA: pcm: export some constraint functions |
| |
At Thu, 6 Feb 2014 09:41:48 +0100, Jean-Francois Moine wrote: > > The functions snd_pcm_hw_constraint_mask() and > snd_pcm_hw_constraint_mask64() are needed to add audio constraints > to substreams at open/startup time. > This patch makes them available to ALSA modules.
I guess it's a part of series, right? If so, feel free to take my ack for this patch.
Acked-by: Takashi Iwai <tiwai@suse.de>
BTW, we should use EXPORT_SYMBOL_GPL() for new entries in general. OTOH, it won't match with others in the same file, and it may look inconsistent. So, I don't mind either way.
thanks,
Takashi
> > Signed-off-by: Jean-Francois Moine <moinejf@free.fr> > --- > sound/core/pcm_lib.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c > index a210467..aea4972 100644 > --- a/sound/core/pcm_lib.c > +++ b/sound/core/pcm_lib.c > @@ -1219,6 +1219,7 @@ int snd_pcm_hw_constraint_mask(struct snd_pcm_runtime *runtime, snd_pcm_hw_param > return -EINVAL; > return 0; > } > +EXPORT_SYMBOL(snd_pcm_hw_constraint_mask); > > /** > * snd_pcm_hw_constraint_mask64 - apply the given bitmap mask constraint > @@ -1242,6 +1243,7 @@ int snd_pcm_hw_constraint_mask64(struct snd_pcm_runtime *runtime, snd_pcm_hw_par > return -EINVAL; > return 0; > } > +EXPORT_SYMBOL(snd_pcm_hw_constraint_mask64); > > /** > * snd_pcm_hw_constraint_integer - apply an integer constraint to an interval > -- > 1.9.rc1 >
| |