lkml.org 
[lkml]   [2014]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] media: i2c: Kconfig: create dependency to MEDIA_CONTROLLER for adv7*
Hi Marcus,

On Wed, Feb 5, 2014 at 9:26 PM, Marcus Folkesson
<marcus.folkesson@gmail.com> wrote:
> These chips makes use of the media_entity in the v4l2_subdev struct
> and is therefor dependent of the MEDIA_CONTROLLER config.
>
NAK, as you can currently see these drivers depend on VIDEO_V4L2_SUBDEV_API
config and if you see VIDEO_V4L2_SUBDEV_API depends on MEDIA_CONTROLLER
config so there is no point in adding this dependency.

Thanks,
--Prabhakar Lad

> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
> drivers/media/i2c/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index d18be19..1771b77 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -196,7 +196,7 @@ config VIDEO_ADV7183
>
> config VIDEO_ADV7604
> tristate "Analog Devices ADV7604 decoder"
> - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
> + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
> ---help---
> Support for the Analog Devices ADV7604 video decoder.
>
> @@ -208,7 +208,7 @@ config VIDEO_ADV7604
>
> config VIDEO_ADV7842
> tristate "Analog Devices ADV7842 decoder"
> - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
> + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
> ---help---
> Support for the Analog Devices ADV7842 video decoder.
>
> @@ -431,7 +431,7 @@ config VIDEO_ADV7393
>
> config VIDEO_ADV7511
> tristate "Analog Devices ADV7511 encoder"
> - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
> + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
> ---help---
> Support for the Analog Devices ADV7511 video encoder.
>
> --
> 1.7.10.4
>


\
 
 \ /
  Last update: 2014-02-06 09:41    [W:1.036 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site