lkml.org 
[lkml]   [2014]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 09/11] x86: perf: intel_pt: Add core dump functionality
Date
Alexander Shishkin <alexander.shishkin@linux.intel.com> writes:
> +
> +static void pt_trace_core_output(struct coredump_params *cprm,
> + struct perf_event *event,
> + unsigned long len)
> +{
> + struct pt_buffer *buf;
> + u64 from, to;
> + int ret;
> +
> + buf = itrace_priv(event);
> +
> + if (!dump_emit(cprm, pt_pmu.capstr, pt_pmu.caplen))
> + return;

It would be nicer if this was a separate note, instead of just being
concatenated with the rest of the data.

Would make simpler parsing and be cleaner.

-Andi

--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2014-02-07 01:21    [W:0.230 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site