Messages in this thread | | | Date | Thu, 6 Feb 2014 21:52:35 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH V3 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast |
| |
On Thu, 6 Feb 2014, Preeti U Murthy wrote: > On 02/06/2014 09:33 PM, Thomas Gleixner wrote: > > On Thu, 6 Feb 2014, Preeti U Murthy wrote: > > > > Compiler warnings are not so important, right? > > > > kernel/time/tick-broadcast.c: In function ‘tick_broadcast_oneshot_control’: > > kernel/time/tick-broadcast.c:700:3: warning: ‘return’ with no value, in function returning non-void [-Wreturn-type] > > kernel/time/tick-broadcast.c:711:3: warning: ‘return’ with no value, in function returning non-void [-Wreturn-type] > > My apologies for this, will make sure this will not repeat. On compilation I > did not receive any warnings with the additional compile time flags too.I > compiled it on powerpc. Let me look into why the warnings did not show up. > Nevertheless I should have taken care of this even by simply looking at the > code.
Huch, PPC seems to have an extra stupid version of gcc :)
> The cpuidle patch then is below. The trace_cpu_idle_rcuidle() functions have > been moved around so that the broadcast CPU does not trace any idle event > and that the symmetry between the trace functions and the call to the > broadcast framework is maintained. Wow, it does become very simple :)
Indeed :)
Care to resend the whole lot with all fixes applied and perhaps compile tested on x86 :)
Thanks,
tglx | |