lkml.org 
[lkml]   [2014]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [trivial] Comment improvements for lp5523 and friend
On Thu, Jan 9, 2014 at 3:13 PM, Pavel Machek <pavel@ucw.cz> wrote:
> Add some comments that are not obvious from first look at the driver
> to lp5523, fix typo in lp8501.
>

Milo, can you take a look at this. If it's OK, I will take it.

-Bryan

> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
> index c00f55e4..ac64ebc 100644
> --- a/drivers/leds/leds-lp5523.c
> +++ b/drivers/leds/leds-lp5523.c
> @@ -34,7 +34,15 @@
>
> #include "leds-lp55xx-common.h"
>
> -#define LP5523_PROGRAM_LENGTH 32
> +#define LP5523_PROGRAM_LENGTH 32 /* bytes */
> +/* Memory is used like this:
> + 0x00 engine 1 program
> + 0x10 engine 2 program
> + 0x20 engine 3 program
> + 0x30 engine 1 muxing info
> + 0x40 engine 2 muxing info
> + 0x50 engine 3 muxing info
> +*/
> #define LP5523_MAX_LEDS 9
>
> /* Registers */
> index 8d55a780..ae5c6fe 100644
> --- a/drivers/leds/leds-lp8501.c
> +++ b/drivers/leds/leds-lp8501.c
> @@ -262,7 +262,7 @@ static void lp8501_firmware_loaded(struct lp55xx_chip *chip)
> }
>
> /*
> - * Program momery sequence
> + * Program memory sequence
> * 1) set engine mode to "LOAD"
> * 2) write firmware data into program memory
> */
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2014-02-06 21:21    [W:0.099 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site