lkml.org 
[lkml]   [2014]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] clk: mvebu: fix clk init order
On Thu, Feb 06, 2014 at 02:08:39PM -0300, Ezequiel Garcia wrote:
> On Wed, Feb 05, 2014 at 01:34:57PM -0500, Jason Cooper wrote:
> > On Sat, Jan 25, 2014 at 07:19:06PM +0100, Sebastian Hesselbarth wrote:
> > > This patch set fixes clk init order that went upside-down with
> > > v3.14. I haven't really investigated what caused this, but I assume
> > > it is related with DT node reordering by addresses.
> > >
> > > Anyway, with v3.14 for MVEBU SoCs, the clock gating driver gets
> > > registered before core clocks driver. Unfortunately, we cannot
> > > return -EPROBE_DEFER in drivers initialized by clk_of_init. As the
> > > init order for our drivers is always core clocks before clock gating,
> > > we maintain init order ourselves by hooking CLK_OF_DECLARE to one
> > > init function that will register core clocks before clock gating
> > > driver.
> > >
> > > This patch is based on pre-v3.14-rc1 mainline and should go in as
> > > fixes for it. As we now send MVEBU clk pull-requests to Mike directly,
> > > I suggest Jason picks it up as a topic branch.
> > >
> > > The patches have been boot tested on Dove and compile-tested only
> > > for Kirkwood, Armada 370 and XP.
> > >
> > > Sebastian Hesselbarth (4):
> > > clk: mvebu: armada-370: maintain clock init order
> > > clk: mvebu: armada-xp: maintain clock init order
> > > clk: mvebu: dove: maintain clock init order
> > > clk: mvebu: kirkwood: maintain clock init order
> > >
> > > drivers/clk/mvebu/armada-370.c | 21 ++++++++++-----------
> > > drivers/clk/mvebu/armada-xp.c | 20 +++++++++-----------
> > > drivers/clk/mvebu/dove.c | 19 +++++++++----------
> > > drivers/clk/mvebu/kirkwood.c | 34 ++++++++++++++++------------------
> > > 4 files changed, 44 insertions(+), 50 deletions(-)
> >
> > Whole series applied to mvebu/clk-fixes.
> >
>
> FWIW, Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>
> Observed "division by zero" get fixed by this, on A370 Mirabox, Kirkwood
> Topkick and Dove Cubox.

Added for patches 1, 3, and 4 (all but armada-xp.c) Thanks for testing.

thx,

Jason.


\
 
 \ /
  Last update: 2014-02-06 19:41    [W:0.482 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site