Messages in this thread | | | Date | Thu, 6 Feb 2014 14:10:40 -0300 | From | Ezequiel Garcia <> | Subject | Re: [PATCH 0/3] irqchip: orion: bridge irq fixes for v3.14-rc1 |
| |
On Tue, Feb 04, 2014 at 11:54:15PM -0500, Jason Cooper wrote: > On Thu, Jan 23, 2014 at 11:38:03PM +0100, Sebastian Hesselbarth wrote: > > This is a small patch set to fix some shortcomings how Orion bridge > > irqs are handled. The patches are based on v3.13-rc8 and should go > > into v3.14. They can possibly also marked for -stable down to v3.10. > > > > This patches are the result of a discussion about a stale watchdog irq, > > that can accidentially trigger the watchdog's irq handler and cause a > > reset [1]. > > > > The first patch will add a write to clear already pending interrupts > > on init. The second patch replaces handle_level_irq with handle_edge_irq > > which is more appropriate for bridge irqs which are edge-triggered. > > The last patch finally, fixes stale interrupts by installing an > > .irq_enable callback, that will clear a possible pending interrupt > > before unmasking it. > > > > [1] http://www.spinics.net/lists/arm-kernel/msg302106.html > > > > Sebastian Hesselbarth (3): > > irqchip: orion: clear bridge cause register on init > > irqchip: orion: use handle_edge_irq on bridge irqs > > irqchip: orion: clear stale interrupts in irq_enable > > > > drivers/irqchip/irq-orion.c | 18 ++++++++++++++++-- > > 1 file changed, 16 insertions(+), 2 deletions(-) > > Whole series applied to mvebu-next/irqchip-fixes (v2 for 3/3). Once I > see that the outstanding pull requests for mvebu/irqchip have been > merged into mainline, I'll be changing the name of this branch to > mvebu/irqchip-fixes. I just don't want to upset the applecart atm. > > Oh yeah, Cc'd for stable back to v3.10. >
If you want to pick this:
Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Tested Kirkwood Topkick and Dove Cubox. Quite frankly, I haven't checked this series prevents an "errant watchdog", but just pursued a boot test.
-- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |