Messages in this thread | | | Date | Wed, 5 Feb 2014 17:31:17 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCH] ARM: OMAP2+: Add support for thumb mode on DT booted N900 |
| |
Hi Pali,
On Wed, Feb 05, 2014 at 02:12:56PM +0100, Pali Rohár wrote: > 1) Why are you using if (IS_ENABLED(CONFIG_ARM_ERRATA_430973)) instead #ifdef ?
This is the preferred kernel style as far as I know.
> 2) Why do you not write warning or info when omap type is not > OMAP2_DEVICE_TYPE_SEC (e.g qemu) ?
I assumed, that the workaround is not needed for this device type.
I just added the warning for missing CONFIG_ARM_ERRATA_430973, because its very likely a misconfigured kernel.
-- Sebastian [unhandled content-type:application/pgp-signature] | |