Messages in this thread | | | Date | Wed, 5 Feb 2014 06:55:52 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf tools: Handle PERF_RECORD_HEADER_EVENT_TYPE properly |
| |
* Jiri Olsa <jolsa@redhat.com> wrote:
> We removed event types from data file in following commits: > 6065210 perf tools: Remove event types framework completely > 44b3c57 perf tools: Remove event types from perf data file > > We no longer need this information, because we can get it > directly from tracepoints. > > But we still need to handle PERF_RECORD_HEADER_EVENT_TYPE > event for the sake of old perf data files created in pipe > mode like: > > $ perf.3.4 record -o - foo >perf.data > $ perf.312 report -i - < perf.data > > Reported-by: Stephane Eranian <eranian@google.com> > Signed-off-by: Jiri Olsa <jolsa@redhat.com> > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > Cc: David Ahern <dsahern@gmail.com> > --- > tools/perf/util/session.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c > index 0b39a48..5da6ce7 100644 > --- a/tools/perf/util/session.c > +++ b/tools/perf/util/session.c > @@ -1008,6 +1008,12 @@ static int perf_session__process_user_event(struct perf_session *session, union > if (err == 0) > perf_session__set_id_hdr_size(session); > return err; > + case PERF_RECORD_HEADER_EVENT_TYPE: > + /* > + * Depreceated, but we need to handle it for sake > + * of old data files create in pipe mode. > + */
Two small speling nits:
s/Depreceated /Deprecated
s/create /created
Ack otherwise.
Thanks,
Ingo
| |