Messages in this thread | | | From | Jim Lin <> | Date | Wed, 5 Feb 2014 18:26:35 +0800 | Subject | RE: [PATCH v3 3/6] misc: fuse: Add efuse driver for Tegra |
| |
Please ignore my comment. I will try to use exported tegra_fuse_readl().
-----Original Message----- From: Peter De Schrijver [mailto:pdeschrijver@nvidia.com] Sent: Monday, February 03, 2014 10:15 PM To: Jim Lin Cc: linux-arm-kernel@lists.infradead.org; linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org; Rob Landley; Stephen Warren; Thierry Reding; Grant Likely; Rob Herring; Danny Huang; linux-doc@vger.kernel.org; devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/6] misc: fuse: Add efuse driver for Tegra
On Wed, Jan 29, 2014 at 03:26:18AM +0100, Jim Lin wrote: > On Wed, 2014-01-29 at 07:36 +0800, Peter De Schrijver wrote: > > Implement fuse driver for Tegra20, Tegra30, Tegra114 and Tegra124. > > > > Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> > > --- > > Documentation/ABI/testing/sysfs-driver-tegra-fuse | 8 + > > drivers/misc/fuse/Makefile | 1 + > > drivers/misc/fuse/tegra/Makefile | 7 + > > drivers/misc/fuse/tegra/fuse-tegra.c | 228 ++++++++++++++++ > > drivers/misc/fuse/tegra/fuse-tegra20.c | 136 ++++++++++ > > drivers/misc/fuse/tegra/fuse-tegra30.c | 178 +++++++++++++ > > drivers/misc/fuse/tegra/fuse.h | 82 ++++++ > Could we move this fuse.h to other folder under /include/linux (like > /include/linux/platform_data) for other driver to include?
I don't think we should expose everything in fuse.h to the world.
> So other driver can invoke function to read fuse data if needed.
Which functionality do you want? Just reading the fuse data exposed in the sysfs file from a driver? exporting tegra_fuse_readl() should do that I think?
Cheers,
Peter.
--nvpublic
| |