Messages in this thread Patch in this message | | | From | Boris BREZILLON <> | Subject | [PATCH] clk: add strict of_clk_init dependency check | Date | Wed, 5 Feb 2014 10:48:00 +0100 |
| |
The parent dependency check is only available on the first parent of a given clk.
Add support for strict dependency check: all parents of a given clk must be initialized.
Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com> ---
Hello Gregory,
This patch adds support for strict check on clk dependencies (check if all parents specified by an DT clk node are initialized).
I'm not sure this is what you were expecting (maybe testing the first parent is what you really want), so please feel free to tell me if I'm wrong.
Best Regards,
Boris
drivers/clk/clk.c | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index beb0f8b..6849769 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2543,22 +2543,37 @@ static int parent_ready(struct device_node *np) { struct of_phandle_args clkspec; struct of_clk_provider *provider; + int num_parents; + bool found; + int i; /* * If there is no clock parent, no need to wait for them, then * we can consider their absence as being ready */ - if (of_parse_phandle_with_args(np, "clocks", "#clock-cells", 0, - &clkspec)) + num_parents = of_count_phandle_with_args(np, "clocks", "#clock-cells"); + if (num_parents <= 0) return 1; - /* Check if we have such a provider in our array */ - list_for_each_entry(provider, &of_clk_providers, link) { - if (provider->node == clkspec.np) + for (i = 0; i < num_parents; i++) { + if (of_parse_phandle_with_args(np, "clocks", "#clock-cells", i, + &clkspec)) return 1; + + /* Check if we have such a provider in our array */ + found = false; + list_for_each_entry(provider, &of_clk_providers, link) { + if (provider->node == clkspec.np) { + found = true; + break; + } + } + + if (!found) + return 0; } - return 0; + return 1; } /** -- 1.7.9.5
| |