Messages in this thread | | | Date | Tue, 04 Feb 2014 20:41:24 -0800 (PST) | Subject | Re: [bisected] Re: WARNING: at net/ipv4/devinet.c:1599 | From | David Miller <> |
| |
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Tue, 4 Feb 2014 21:03:24 +0100
> On Tue, Feb 4, 2014 at 8:20 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: >> On Tue, Feb 4, 2014 at 7:08 PM, Cong Wang <cwang@twopensource.com> wrote: >>> On Tue, Feb 4, 2014 at 6:19 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: >>>> >>>> Anyone with a clue? >>>> >>> >>> Looks like we need: >>> >>> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c >>> index ac2dff3..bdbf68b 100644 >>> --- a/net/ipv4/devinet.c >>> +++ b/net/ipv4/devinet.c >>> @@ -1443,7 +1443,8 @@ static size_t inet_nlmsg_size(void) >>> + nla_total_size(4) /* IFA_LOCAL */ >>> + nla_total_size(4) /* IFA_BROADCAST */ >>> + nla_total_size(IFNAMSIZ) /* IFA_LABEL */ >>> - + nla_total_size(4); /* IFA_FLAGS */ >>> + + nla_total_size(4) /* IFA_FLAGS */ >>> + + nla_total_size(sizeof(struct ifa_cacheinfo)); /* >>> IFA_CACHEINFO */ >>> } >> >> Thanks for your suggestion, but it doesn't help :-( > > Bummer, I applied it to the wrong tree. > > Yes, it works, thanks a lot! > > David, Jiri, is this the right fix, or just a band-aid?
It looks correct, and if you look ipv6 does this correctly already, someone please submit this formally.
| |