lkml.org 
[lkml]   [2014]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 091/133] vfs: Remove second variable named error in __dentry_path
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Eric W. Biederman" <ebiederm@xmission.com>

    commit a8323da0366d3398eda62741d2ac1130c8a172ed upstream.

    In commit 232d2d60aa5469bb097f55728f65146bd49c1d25
    Author: Waiman Long <Waiman.Long@hp.com>
    Date: Mon Sep 9 12:18:13 2013 -0400

    dcache: Translating dentry into pathname without taking rename_lock

    The __dentry_path locking was changed and the variable error was
    intended to be moved outside of the loop. Unfortunately the inner
    declaration of error was not removed. Resulting in a version of
    __dentry_path that will never return an error.

    Remove the problematic inner declaration of error and allow
    __dentry_path to return errors once again.

    Cc: Waiman Long <Waiman.Long@hp.com>
    Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/dcache.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/fs/dcache.c
    +++ b/fs/dcache.c
    @@ -3140,7 +3140,6 @@ restart:
    read_seqbegin_or_lock(&rename_lock, &seq);
    while (!IS_ROOT(dentry)) {
    struct dentry *parent = dentry->d_parent;
    - int error;

    prefetch(parent);
    error = prepend_name(&end, &len, &dentry->d_name);



    \
     
     \ /
      Last update: 2014-02-05 02:01    [W:4.652 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site