lkml.org 
[lkml]   [2014]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 058/104] mfd: max77686: Fix regmap resource leak on driver remove
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Krzysztof Kozlowski <k.kozlowski@samsung.com>

    commit 74142ffc0b52cfe6f9d2f6f34a5f3eedbfe3ce51 upstream.

    The regmap used by max77686 MFD driver was not freed with regmap_exit()
    on driver exit. This lead to leak of resources.

    Replace regmap_init_i2c() call in driver probe with initialization of
    managed register map so the regmap will be properly freed by the device
    management code.

    Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mfd/max77686.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mfd/max77686.c
    +++ b/drivers/mfd/max77686.c
    @@ -102,7 +102,7 @@ static int max77686_i2c_probe(struct i2c
    max77686->irq_gpio = pdata->irq_gpio;
    max77686->irq = i2c->irq;

    - max77686->regmap = regmap_init_i2c(i2c, &max77686_regmap_config);
    + max77686->regmap = devm_regmap_init_i2c(i2c, &max77686_regmap_config);
    if (IS_ERR(max77686->regmap)) {
    ret = PTR_ERR(max77686->regmap);
    dev_err(max77686->dev, "Failed to allocate register map: %d\n",



    \
     
     \ /
      Last update: 2014-02-05 01:01    [W:2.149 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site