Messages in this thread | | | Subject | Re: [PATCH V3] net/dt: Add support for overriding phy configuration from device tree | From | Ben Hutchings <> | Date | Tue, 04 Feb 2014 21:40:40 +0000 |
| |
On Tue, 2014-02-04 at 12:39 -0800, Florian Fainelli wrote: > 2014-01-17 Matthew Garrett <matthew.garrett@nebula.com>: > > Some hardware may be broken in interesting and board-specific ways, such > > that various bits of functionality don't work. This patch provides a > > mechanism for overriding mii registers during init based on the contents of > > the device tree data, allowing board-specific fixups without having to > > pollute generic code. > > It would be good to explain exactly how your hardware is broken > exactly. I really do not think that such a fine-grained setting where > you could disable, e.g: 100BaseT_Full, but allow 100BaseT_Half to > remain usable makes that much sense. In general, Gigabit might be > badly broken, but 100 and 10Mbits/sec should work fine. How about the > MASTER-SLAVE bit, is overriding it really required?
Yes, it is entirely possible that one or other of the clock modes (locally generated vs recovered) is not reliable.
> Is not a PHY fixup registered for a specific OUI the solution you are > looking for? [...]
The fault is in the board, not the PHY.
Ben.
-- Ben Hutchings One of the nice things about standards is that there are so many of them. [unhandled content-type:application/pgp-signature] | |