lkml.org 
[lkml]   [2014]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] ath10k: Get rid of superfluous call to pci_disable_msi()
    On Tue, Feb 04, 2014 at 08:32:12PM +0200, Kalle Valo wrote:
    > Alexander Gordeev <agordeev@redhat.com> writes:
    >
    > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
    > > ---
    > > drivers/net/wireless/ath/ath10k/pci.c | 2 --
    > > 1 files changed, 0 insertions(+), 2 deletions(-)
    > >
    > > diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
    > > index 29fd197..6525e1f 100644
    > > --- a/drivers/net/wireless/ath/ath10k/pci.c
    > > +++ b/drivers/net/wireless/ath/ath10k/pci.c
    > > @@ -2414,8 +2414,6 @@ static int ath10k_pci_init_irq(struct ath10k *ar)
    > > ret = pci_enable_msi_block(ar_pci->pdev, ar_pci->num_msi_intrs);
    > > if (ret == 0)
    > > return 0;
    > > - if (ret > 0)
    > > - pci_disable_msi(ar_pci->pdev);
    >
    > I don't understand how this is superfluous. When I read the
    > documentation for pci_enable_msi_block() it states that if it can't
    > allocate all requests, it will return the number requests it could
    > allocate. And in that case we want to fall back other modes.
    >
    > Am I missing something?

    Yep. The documentation states 'could have been allocated', not 'could
    allocate'. IOW, MSIs are *not* enabled if a positive value returned.
    The code I changed tries to disable MSIs in such case, although it is
    not necessary, nor required. Just superfluous.

    HTH.

    --
    Regards,
    Alexander Gordeev
    agordeev@redhat.com


    \
     
     \ /
      Last update: 2014-02-05 01:01    [W:4.448 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site