lkml.org 
[lkml]   [2014]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13 064/140] uio: fix devm_request_irq usage
    Date
    3.13-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Aaro Koskinen <aaro.koskinen@nsn.com>

    commit 632fefaf1fff7c344191c363e08a43cf006fe60e upstream.

    Commit e6789cd3dfb553077606ccafeb05e0043f072481 (uio: Simplify uio error
    path by using devres functions) converted uio to use devm_request_irq().
    This introduced a change in behaviour since the IRQ is associated with
    the parent device instead of the created UIO device. The IRQ will remain
    active after uio_unregister_device() is called, and some drivers will
    crash because of this. The patch fixes this.

    Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/uio/uio.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/uio/uio.c
    +++ b/drivers/uio/uio.c
    @@ -847,7 +847,7 @@ int __uio_register_device(struct module
    info->uio_dev = idev;

    if (info->irq && (info->irq != UIO_IRQ_CUSTOM)) {
    - ret = devm_request_irq(parent, info->irq, uio_interrupt,
    + ret = devm_request_irq(idev->dev, info->irq, uio_interrupt,
    info->irq_flags, info->name, idev);
    if (ret)
    goto err_request_irq;



    \
     
     \ /
      Last update: 2014-02-05 01:01    [W:2.084 / U:0.668 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site