Messages in this thread | | | Date | Tue, 4 Feb 2014 23:21:17 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 2/6] regulator: add bcm59056 pmu DT binding |
| |
On Tue, Feb 04, 2014 at 04:16:38PM -0500, Matt Porter wrote: > On Tue, Feb 04, 2014 at 05:23:09PM +0000, Mark Brown wrote:
> > Is this really only a regulator - does the chip have no other functions?
> It's your average multi-function device with other functions as you are > suspecting. Buried in the the MFD driver comments is me admitting that > I need to split this into two bindings. The base device, "bcm59056" and > then "bcm59056-reg". So point noted, I'll updated with the appropriate > binding for each.
It doesn't need to be two bindings - just move it to the MFD section and document it there. The existing binding is totally fine from a regulator standpoint and should continue to be so as other functions are added. [unhandled content-type:application/pgp-signature] | |